Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[i18n] Test EUI i18n tokens coverage #106377

Merged
merged 6 commits into from
Jul 22, 2021
Merged

[i18n] Test EUI i18n tokens coverage #106377

merged 6 commits into from
Jul 22, 2021

Conversation

Bamieh
Copy link
Member

@Bamieh Bamieh commented Jul 21, 2021 •
edited
Loading

Summary

Building on top of original PR #99613

Add tests to ensure that the i18n tokens from @elastic/eui and their mapping in Kibana are in sync.

The tests are meant to apply the following checks:

  1. Are we missing any label? Do we have any label that no longer applies?
  2. The labels that require values, are they mapped as functions?
  3. Are the EUI Tokens mapped to core.{EUI Tokens}?
  4. Does the defaultValue match EUI's defString for every token?
  5. Are we using the same values as expected in the props of EuiI18n?

Checklist

Delete any items that are not applicable to this PR.

For maintainers

Closes #99759
Closes #74657

@Bamieh Bamieh added Project:i18n v8.0.0 release_note:skip Skip the PR/issue when compiling release notes auto-backport Deprecated - use backport:version if exact versions are needed v7.15.0 labels Jul 21, 2021
@Bamieh Bamieh mentioned this pull request Jul 21, 2021
Closed
2 tasks
@Bamieh Bamieh marked this pull request as ready for review July 21, 2021 15:17
@Bamieh Bamieh requested review from a team as code owners July 21, 2021 15:17
joshdover
joshdover approved these changes Jul 22, 2021
View reviewed changes
src/core/public/i18n/i18n_eui_mapping.tsx Outdated Show resolved Hide resolved
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
core 421.7KB 421.7KB +6.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@Bamieh Bamieh merged commit dbfca5c into elastic:master Jul 22, 2021
@Bamieh Bamieh deleted the i18n/eui_tokens branch July 22, 2021 21:26
@kibanamachine
Copy link
Contributor

💔 Backport failed

Status Branch Result
❌ 7.x Commit could not be cherrypicked due to conflicts

To backport manually run:
node scripts/backport --pr 106377

@Bamieh Bamieh mentioned this pull request Jul 26, 2021
Merged
Bamieh added a commit that referenced this pull request Jul 26, 2021
@Bamieh
[i18n] Test EUI i18n tokens coverage (#106377) (#106702)
9790cf7 
# Conflicts:
#	x-pack/plugins/translations/translations/ja-JP.json
#	x-pack/plugins/translations/translations/zh-CN.json
@thompsongl thompsongl mentioned this pull request Jul 28, 2021
Merged
@afharo afharo mentioned this pull request Aug 25, 2021
Merged
@Bamieh Bamieh mentioned this pull request Nov 22, 2021
Closed
2 tasks
@sakurai-youhei sakurai-youhei mentioned this pull request Apr 30, 2024
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joshdover joshdover joshdover approved these changes

Assignees
No one assigned
Labels
auto-backport Deprecated - use backport:version if exact versions are needed Project:i18n release_note:skip Skip the PR/issue when compiling release notes v7.15.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[i18n] Generate EUI tokens mapping automatically from i18ntokens.json EUI labels not translating
3 participants
@Bamieh @kibanamachine @joshdover